[PATCH 3/3] compositor-drm: add sprite support v6

[Benjamin Franzke]

2012/2/14 Jesse Barnes <jbarnes at virtuousgeek.org>:
> On Tue, 14 Feb 2012 10:52:11 +0100
> Benjamin Franzke <benjaminfranzke at googlemail.com> wrote:
>> > +       bo = gbm_bo_create_from_egl_image(c->gbm, c->base.display, es->image,
>> > +                                         es->geometry.width, es->geometry.height,
>> > +                                         GBM_BO_USE_SCANOUT);
>> > +       format = gbm_bo_get_format(bo);
>>
>> Havent seen a patch for GBM, that introduces gbm_bo_get_format.
>> From how you use format, it looks like you expect it to return a DRM_FORMAT_*?
>> Since GBM is in general modesetting-api independent it should return a
>> GBM_BO_FORMAT_*.
>
> Right, Kristian suggested the new API and has a patch for it.  It would
> be nice if the values were compatible with the DRM versions, otherwise
> we'll have to add a conversion function so we get the right numbers.
Well, ok, I would also be fine with making the GBM formats compatible
with DRM formats, so that we dont need a conversion function.
>
>> The reason for that is, that I want to keep it possible to implement
>> OpenWF Display with GBM, without DRM.
>> So that we have practical example and API towards the
>> Wayland-needs-KMS misinformation.
>
> Yep, understood.  Does OpenWF have the notion of surface formats like
> this?

No, the API doesnt care at all about it, its up to the
platform-dependent underlying API, which is GBM for us.
So with OpenWF we'd check the GBM format inside OpenWF and then fail to
create a so called WFDSource, if the format cant be used.
>
> --
> Jesse Barnes, Intel Open Source Technology Center