[PATCH 0/7] Drag and drop icons

Ander Conselvan de Oliveira ander.conselvan.de.oliveira at intel.com
Wed Feb 15 07:02:51 PST 2012


Here's a second attempt to getting drag and drop icons implemented.
This uses the protocol change Kristian suggested on the previous
thread.

On libwayland-server, we just set wl_input_device::drag_surface and
check it on Weston in different places. However, since there is no
way to trigger a repaint from the library side, I added the attach
with a NULL buffer when the drag ends. But maybe there is a better
solution for this.

Patch 0002 is just a bug fix so that this attach won't cause Weston
to crash. Patch 0003 changes shell so that surfaces with no type are
not mapped, thus preventing the mapping of the drag surface when an
attach happens after the drag ended.

Wayland patch:
  data_device: get rid of attach request

Weston patches:
  compositor: fix two crashs on surface_attach() with null buffer
  shell: don't map surfaces with type NONE
  compositor: add a way to disable picking of client surfaces
  shell: update position of surfaces with type none on map()
  compositor: implement drag'n'drop icons
  clients/dnd: adapt to new data_device icon protocol

 clients/dnd.c      |   21 +++++++++++--
 src/compositor.c   |   80 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 src/compositor.h   |    7 ++++-
 src/shell.c        |   12 ++++++-
 src/tablet-shell.c |    2 +-
 5 files changed, 113 insertions(+), 9 deletions(-)

-- 
1.7.4.1



More information about the wayland-devel mailing list