[protocol PATCH v2 2/2] add set_maximised method for wl_shell_surface interface

[Pekka Paalanen]

On Mon,  9 Jan 2012 22:50:21 +0800
juan.j.zhao at linux.intel.com wrote:

> From: Alex Wu <zhiwen.wu at linux.intel.com>
> 
> add one interface to let the client notify the compositor the maximised operation,
> and then the compositor will send a configure event back to the client 
> 
> Signed-off-by: Juan Zhao <juan.j.zhao at linux.intel.com>
> Signed-off-by: Alex Wu <zhiwen.wu at linux.intel.com>
> 
> ---
>  protocol/wayland.xml |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 041c607..193facf 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -357,6 +357,8 @@
>        <entry name="fill" value="3"/>
>      </enum>
>  
> +    <request name="set_maximised">

Doesn't this need to be <request name="set_maximised"/> to be valid XML?
I.e. missing /.

> +
>      <!-- Popup surfaces.  Will switch an implicit grab into
>           owner-events mode, and grab will continue after the implicit
>           grab ends (button released).  Once the implicit grab is over,

- pq