[protocol PATCH v2 1/2] add parameters for set_fullscreen

[Juan Zhao]

Thank you very much for your input.

On Tue, 2012-01-10 at 13:26 -0800, Bill Spitzak wrote:

> > "scale" is for preferring scaling in the compositor, the application
> > really would like to fill the whole screen, even if it renders a buffer
> > that is too small. The compositor might (be configured to) also switch
> > the video mode, if it wants to scan out the client surface. Scaling
> > would always preserve surface's aspect ratio. The surface is centered.
> 
> If the aspect ratio is preserved (which I agree is a good idea) then 
> this will have black borders as well. There may be a desire to disable 
> the aspect ratio preservation, which would be another mode?
> 
Yeah, good concern, looks like some parameters should be added here? 

> 
> > "force" is like "scale"...
> 
> I don't like this name, "force" implies that the scale will be exact, 
> which this does not do. Maybe "fast scale".
It's OK for me to change a name here. And "fast scale" can not express
the "mode changing" part here and we will also map 1:1 pixel to the
output. How about "resolution" or "mode" or "change"?

> 

> Oversize:
> 
> You need to figure out what should happen if the window is larger than 
> the screen. This is likely a mistake by the client but some predictable 
> result is needed. My best guess is that the window is centered at 1:1 scale.
Agree

Thanks,
Juan