[PATCH v3 4/4] add fullscreen test code

Pekka Paalanen ppaalanen at gmail.com
Mon Jan 16 00:30:42 PST 2012

On Mon, 16 Jan 2012 01:23:17 +0800
juan.j.zhao at linux.intel.com wrote:

> From: Juan Zhao <juan.j.zhao at linux.intel.com>
> F12:Force mode
> F11:Scale mode
> F10:Fill mode
> F09:Maximised
> F08:set_toplevel to reset
> Signed-off-by: Juan Zhao <juan.j.zhao at linux.intel.com>
> Signed-off-by: Zhiwen Wu <zhiwen.wu at linux.intel.com>

For the whole patch set:

On a quick look, it seems that you have addressed all my primary
concerns, either by changing code or justifying your choices. I must
say I didn't carefully follow through the implementations, or test it
yet, though.

It seems that patch 1 uses functions that are introduced only in patch
2, weston_surface_center_on_output() and
weston_surface_set_fullscreen(). On build after patch 1 only, I get:

  CC     desktop_shell_la-shell.lo
shell.c:569:1: warning: initialization from incompatible pointer type
shell.c: In function 'map':
shell.c:1158:3: warning: implicit declaration of function 'weston_surface_set_fullscreen'
shell.c:1161:3: warning: implicit declaration of function 'weston_surface_center_on_output'

Might be good to hear others' comments first, too, if you need to
re-spin this set.


More information about the wayland-devel mailing list