Configuration files (Re: [PATCH] strtol() fails on 32 bit...)

Pekka Paalanen ppaalanen at gmail.com
Mon Jan 30 01:03:56 PST 2012


On Fri, 27 Jan 2012 11:27:48 -0500
Kristian Høgsberg <krh at bitplanet.net> wrote:

> On Fri, Jan 27, 2012 at 10:53 AM, Scott Moreau <oreaus at gmail.com> wrote:
> > ---
> > I'm not sure this is the correct fix but if nothing else, this can serve as a bug report until the tracker is up. The problem is that config-parser sets variables to incorrect values on 32 bit systems which causes problems. Specifically, this fixes a bug where the background color value is wrong. Sometimes alpha is not 1 and it leaves ghost trails for any movement.
> 
> Ah, yes.  A better fix would be to add a CONFIG_KEY_UNSIGNED_INTEGER
> type and handle the conversion with strtoul instead.

I'm sceptical about the whole idea of expressing an ARGB tuplet as a
single integer because of possible endianness issues.

I understand it is convenient for now, and the config parser is not
supposed to grow into a full-featured config system. Should we consider
starting to use a proper configuration library, whatever that might be?

Maybe it could be a newbie task to find and integrate one?
To add to Vignatti's blog list of tasks. ;-)


Thanks,
pq


More information about the wayland-devel mailing list