Proposed rearrangement of wl_event_loop_dispatch

David Herrmann dh.herrmann at googlemail.com
Mon Jul 9 12:14:35 PDT 2012


Hi Bill

On Mon, Jul 9, 2012 at 8:06 PM, Bill Spitzak <spitzak at gmail.com> wrote:
> Any comments on this?
>

It is much easier to comment on and follow patches if you include them
inline. Also, where is the git headline? I recommend using
git-format-patch and optionally git-send-email (even for RFC patches).

Regarding your patch:
Why do you continuously set "timeout" to 0 during the loop? It should
be sufficient to set it one time only. Also, please add a newline
after while() but before the loop-body.

Regards
David


More information about the wayland-devel mailing list