[PATCH 3/3] shell: avoid unnecessary busy cursor sending when not-responsing-ping client

juan.j.zhao at linux.intel.com juan.j.zhao at linux.intel.com
Tue Jul 17 22:25:15 PDT 2012


From: Juan Zhao <juan.j.zhao at linux.intel.com>

When the client didn't response to ping event in time, the server
 will do "set_busy_cursor" again and again. In fact it should only need to
 set it at the first time. Because handle_pointer_focus could help to set it,
 when the application was focused.

Signed-off-by: Juan Zhao <juan.j.zhao at linux.intel.com>
---
 src/shell.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/shell.c b/src/shell.c
index 9372edc..04369e8 100644
--- a/src/shell.c
+++ b/src/shell.c
@@ -911,6 +911,11 @@ ping_timeout_handler(void *data)
 	struct shell_surface *shsurf = data;
 	struct weston_seat *seat;
 
+	/* client is already unresponding,
+	 * no need to generate extra set_cursor action */
+	if (shsurf->unresponsive)
+		return 1;
+
 	/* Client is not responding */
 	shsurf->unresponsive = 1;
 
-- 
1.7.11



More information about the wayland-devel mailing list