[PATCH weston 2/2] shell: Remove unused pointer_end_grab

Tiago Vignatti tiago.vignatti at linux.intel.com
Fri Jul 20 11:43:48 PDT 2012


On 07/20/2012 07:41 PM, Tiago Vignatti wrote:
> shell_grab_end already does that for us.
>
> Signed-off-by: Tiago Vignatti <tiago.vignatti at intel.com>
> ---
>   src/shell.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/shell.c b/src/shell.c
> index 344c690..ad26ce6 100644
> --- a/src/shell.c
> +++ b/src/shell.c
> @@ -810,7 +810,6 @@ move_grab_button(struct wl_pointer_grab *grab,
>   	if (pointer->button_count == 0 &&
>   	    state == WL_POINTER_BUTTON_STATE_RELEASED) {
>   		shell_grab_end(shell_grab);
> -		wl_pointer_end_grab(pointer);
>   		free(grab);
>   	}
>   }
> @@ -830,7 +829,6 @@ busy_cursor_grab_focus(struct wl_pointer_grab *base,
>
>   	if (grab->grab.focus != surface) {
>   		shell_grab_end(grab);
> -		wl_pointer_end_grab(pointer);
>   		free(grab);
>   	}
>   }

can you please amend deletion of struct wl_pointer *pointer in this 
function then? It's being unused after this patch.


Thank you,

Tiago


More information about the wayland-devel mailing list