[PATCH weston] wcap: Fix up --help.

Scott Moreau oreaus at gmail.com
Mon Jul 23 10:51:06 PDT 2012


On Mon, Jul 23, 2012 at 9:09 AM, Kristian Høgsberg <hoegsberg at gmail.com>wrote:

> On Sun, Jul 22, 2012 at 06:51:27PM -0600, Scott Moreau wrote:
> > ---
> >  wcap/main.c |    9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
>
> I don't like the example filenames in the help text, but you have a
> point that dumping YUV4MPEG2 to the terminal isn't nice and it's not
> clear that that's what --yuv4mpeg2 does.  Instead, I've gone for this
> change, which clarifies help message slightly and then catches the
> dump-to-terminal case and provides an example of how to encode to webm
> in that case.
>

That's cool, the whole point was to fix up the usage output. However, you
still have a typo here.
Notice the difference in the --yuv4mpeg2 option name here. One says
yuv4mpeg2, and the other
yuv2mpeg4. This was the reason for my initial confusion.


                "[--help] [--yuv4mpeg2] [--frame=<frame>] [--all] \n"
>
-               "\t--yuv2mpeg4\t\tdump wcap file in yuv4mpeg format\n"
> +               "\t--yuv2mpeg4\t\tdump wcap file to stdout in yuv4mpeg
> format\n"
>
>


Scott
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20120723/7c4fb25f/attachment.html>


More information about the wayland-devel mailing list