[PATCH weston 4/5] Make use of new wl_cursors

Daniel Stone daniel at fooishbar.org
Wed Jul 25 06:11:51 PDT 2012


Hi Rob,

On 24 July 2012 13:01, Rob Bradford <rob at robster.org.uk> wrote:
> On 23 July 2012 19:55, Daniel Stone <daniel at fooishbar.org> wrote:
>> -       wl_pointer_set_cursor(input->pointer, input->display->serial,
>> -                             input->pointer_surface,
>> -                             image->hotspot_x, image->hotspot_y);
>>         wl_surface_attach(input->pointer_surface, buffer, 0, 0);
>>         wl_surface_damage(input->pointer_surface, 0, 0,
>>                           image->width, image->height);
>> +       wl_pointer_set_cursor(input->pointer, input->display->serial,
>> +                             input->pointer_surface,
>> +                             image->hotspot_x, image->hotspot_y);
>>  }
>>
>
> Is this switch in order important ? In all the toolkits i've copied
> the old ordering of set_cursor, attach, damage in. Should those be
> changed?

Only due to the ->configure() handling change, but I'm going to back
that out after Ander's comments, so I wouldn't worry about that.

Cheers,
Daniel


More information about the wayland-devel mailing list