[PATCH 2/2] gears: show FPS count (as in glxgears from mesa/demos)

[Kristian Høgsberg]

On Wed, Jul 25, 2012 at 1:41 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Wed, 25 Jul 2012 18:20:34 +0200
> Olivier BLIN <olivier.blin at softathome.com> wrote:
>
>> On 07/25/2012 05:00 PM, Pekka Paalanen wrote:
>> > Gears will now need the same disclaimer as glxgears has, otherwise end
>> > users will start using this as a generic Wayland performance
>> > benchmark. I can imagine some headlines on Phoronix when they compare
>> > Wayland gears with glxgears and draw wildly incorrect conclusions. I
>> > hope you will add a message explaining what this "fps" number really
>> > means and what it can be used for. Thanks, pq
>> Right, it would only make sense for a fps count sensibly lower than page
>> flip or refresh frequency.
>>
>> This small patch has been useful for me with a fullscreen 1080p gears,
>> to check that llvmpipe was performing faster than DRI (using a software
>> fallback on Intel Q35).
>> But I agree that with better performing hardware or drivers, it would
>> not be a good metric.
>>
>> Should I still rework the patch with a warning message?
>
> Personally I would like to see that, yeah, but it's up to krh, really.
> Can't hurt? Could be a follow-up patch, too.

Yeah, I think we should add the warning.

Kristian