wayland-devel Digest, Vol 22, Issue 88
nerdopolis
bluescreen_avenger at verizon.net
Tue Jul 31 11:49:01 PDT 2012
On Tuesday, July 31, 2012 09:59:34 AM wayland-devel-request at lists.freedesktop.org wrote:
> Send wayland-devel mailing list submissions to
> wayland-devel at lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> or, via email, send a message with subject or body 'help' to
> wayland-devel-request at lists.freedesktop.org
>
> You can reach the person managing the list at
> wayland-devel-owner at lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of wayland-devel digest..."
>
>
> Today's Topics:
>
> 1. [PATCH weston 8/8] simple-touch: use proper damage in
> touch_paint() (Pekka Paalanen)
> 2. Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> (Andre Heider)
> 3. Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> (Pekka Paalanen)
> 4. Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> (Andre Heider)
> 5. [PATCH xserver 1/2] xwayland: remove non-existent private
> headers (Tiago Vignatti)
> 6. [PATCH xserver 2/2] xwayland: fix motion coordinates
> (Tiago Vignatti)
> 7. [PATCH weston] configure: link image libs with libshared
> (Tiago Vignatti)
> 8. Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> (Pekka Paalanen)
> 9. Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> (Andre Heider)
> 10. [PATCH] protocol: Remove "repeat" from "key_state" (Andre Heider)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Tue, 31 Jul 2012 13:21:13 +0300
> From: Pekka Paalanen <ppaalanen at gmail.com>
> To: krh at bitplanet.net
> Cc: Pekka Paalanen <ppaalanen at gmail.com>,
> wayland-devel at lists.freedesktop.org
> Subject: [PATCH weston 8/8] simple-touch: use proper damage in
> touch_paint()
> Message-ID: <1343730073-13027-8-git-send-email-ppaalanen at gmail.com>
>
> Should reduce update overhead.
>
> Signed-off-by: Pekka Paalanen <ppaalanen at gmail.com>
> ---
> clients/simple-touch.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/clients/simple-touch.c b/clients/simple-touch.c
> index f8afbb0..6087fe4 100644
> --- a/clients/simple-touch.c
> +++ b/clients/simple-touch.c
> @@ -141,7 +141,7 @@ touch_paint(struct touch *touch, int32_t x, int32_t y, int32_t id)
> p += touch->width;
> p[2] = c;
>
> - wl_surface_damage(touch->surface, 0, 0, touch->width, touch->height);
> + wl_surface_damage(touch->surface, x - 2, y - 2, 5, 5);
> }
>
> static void
> > Without this, it won't get any input anymore.
>
> I noticed this too while fixing up SDL for 0.95. It wasn't obvious why
> input events were not delivered anymore.
> Maybe weston should log something about non-responsive client?
>
>
> ------------------------------
>
> Message: 3
> Date: Tue, 31 Jul 2012 15:32:27 +0300
> From: Pekka Paalanen <ppaalanen at gmail.com>
> To: Andre Heider <a.heider at gmail.com>
> Cc: krh at bitplanet.net, wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> Message-ID: <20120731153227.363679ed at gmail.com>
> Content-Type: text/plain; charset=US-ASCII
>
> On Tue, 31 Jul 2012 14:07:01 +0200
> Andre Heider <a.heider at gmail.com> wrote:
>
> > On Tue, Jul 31, 2012 at 12:21 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > > Without this, it won't get any input anymore.
> >
> > I noticed this too while fixing up SDL for 0.95. It wasn't obvious why
> > input events were not delivered anymore.
> > Maybe weston should log something about non-responsive client?
>
> Hi,
>
> it would be hard to spot in the log. Weston already changes the pointer
> to a busy cursor, when over an unresponsive surface.
> Did that not work for you, or did you just miss the connection?
>
> Earlier, an unresposive surface was also grayed out, but that feature
> was removed.
>
>
> Thanks,
> pq
>
>
> ------------------------------
>
> Message: 4
> Date: Tue, 31 Jul 2012 14:44:46 +0200
> From: Andre Heider <a.heider at gmail.com>
> To: Pekka Paalanen <ppaalanen at gmail.com>
> Cc: krh at bitplanet.net, wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> Message-ID:
> <CAHsu+b8wyJeArbf4sdOia9MZAhL3D_4tLqv9aNa2f6DhvwWybA at mail.gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> On Tue, Jul 31, 2012 at 2:32 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > Hi,
> >
> > it would be hard to spot in the log. Weston already changes the pointer
> > to a busy cursor, when over an unresponsive surface.
> > Did that not work for you, or did you just miss the connection?
>
> There wasn't yet any code to handle pointer surfaces, which had all
> sorts of funny effects, so I might have just missed that.
> Let's assume I did, and a busy cursor sounds like a nice solution.
>
> Thanks,
> Andre
>
>
> ------------------------------
>
> Message: 5
> Date: Tue, 31 Jul 2012 15:46:11 +0300
> From: Tiago Vignatti <tiago.vignatti at intel.com>
> To: wayland-devel at lists.freedesktop.org
> Cc: Tiago Vignatti <tiago.vignatti at intel.com>
> Subject: [PATCH xserver 1/2] xwayland: remove non-existent private
> headers
> Message-ID:
> <1343738772-27329-1-git-send-email-tiago.vignatti at intel.com>
>
> (BTW, we gotta use xwl_screen_close somewhere)
>
> Signed-off-by: Tiago Vignatti <tiago.vignatti at intel.com>
> ---
> hw/xfree86/xwayland/xwayland-private.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/hw/xfree86/xwayland/xwayland-private.h b/hw/xfree86/xwayland/xwayland-private.h
> index f697b60..6322060 100644
> --- a/hw/xfree86/xwayland/xwayland-private.h
> +++ b/hw/xfree86/xwayland/xwayland-private.h
> @@ -115,12 +115,6 @@ void xwl_input_teardown(pointer p);
> pointer xwl_input_setup(pointer module, pointer opts, int *errmaj, int *errmin);
> void xwl_input_init(struct xwl_screen *screen);
>
> -void xwl_force_roundtrip(struct xwl_screen *xwl_screen);
> -
> -int wayland_screen_pre_init(struct xwl_screen *screen, int use_drm);
> -int wayland_screen_init(struct xwl_screen *screen);
> -int wayland_screen_close(struct xwl_screen *screen);
> -
> Bool xwl_drm_initialised(struct xwl_screen *screen);
>
> #endif /* _XWAYLAND_PRIVATE_H_ */
> > On Tue, Jul 31, 2012 at 2:32 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > > Hi,
> > >
> > > it would be hard to spot in the log. Weston already changes the pointer
> > > to a busy cursor, when over an unresponsive surface.
> > > Did that not work for you, or did you just miss the connection?
> >
> > There wasn't yet any code to handle pointer surfaces, which had all
> > sorts of funny effects, so I might have just missed that.
> > Let's assume I did, and a busy cursor sounds like a nice solution.
>
> Which (non-existing) code are you referring to?
>
> The unresponsive busy cursor thing is triggered in the desktop-shell
> plugin, and the actual busy cursor is set in the desktop-shell client.
> It does not require any setup from the client that becomes
> unresponsive. Or that is how it is supposed to work.
>
> You were using Weston, and desktop-shell client is working, right?
>
>
> Thanks,
> pq
>
>
> ------------------------------
>
> Message: 9
> Date: Tue, 31 Jul 2012 17:59:03 +0200
> From: Andre Heider <a.heider at gmail.com>
> To: Pekka Paalanen <ppaalanen at gmail.com>
> Cc: krh at bitplanet.net, wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH weston 5/8] simple-touch: respond to ping protocol
> Message-ID:
> <CAHsu+b8egns9C-KFxdG25KXySEeyyeOfH-QJeuVhBaZ3hFD84Q at mail.gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> On Tue, Jul 31, 2012 at 3:00 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > Which (non-existing) code are you referring to?
> >
> > The unresponsive busy cursor thing is triggered in the desktop-shell
> > plugin, and the actual busy cursor is set in the desktop-shell client.
> > It does not require any setup from the client that becomes
> > unresponsive. Or that is how it is supposed to work.
> >
> > You were using Weston, and desktop-shell client is working, right?
>
> Sorry, what I meant is: When the client doesn't set any pointer
> surfaces as it's supposed to, you get the last active cursor when
> entering the window (like the textedit cursor when hovering from a
> terminal to the client's window). That was the case with the SDL
> driver when I started working on it. Since the pointer didn't indicate
> anything useful, I assume I also ignored the busy cursor trying to
> tell me about the clients non-responsiveness.
>
> And I just rechecked, and without the pong response the cursor
> switches to the busy state after a short while, so everything works as
> expected. It was just me ignoring the signs :)
>
> Thanks,
> Andre
>
>
> ------------------------------
>
> Message: 10
> Date: Tue, 31 Jul 2012 18:59:09 +0200
> From: Andre Heider <a.heider at gmail.com>
> To: wayland-devel at lists.freedesktop.org
> Cc: Andre Heider <a.heider at gmail.com>
> Subject: [PATCH] protocol: Remove "repeat" from "key_state"
> Message-ID: <1343753949-11713-1-git-send-email-a.heider at gmail.com>
>
> This is unused and apparently was never implemented.
> ---
> While this might qualify as api breakage, the occurence of the repeat enum
> in public headers might confuse users (read: me). As I understood on irc,
> this will never be implemented, so it can be argued that its even nice to
> point users at non-working code with a compile error.
>
> protocol/wayland.xml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 4b500e6..cfe95c0 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -908,11 +908,9 @@
> <enum name="key_state">
> <description summary="physical key state">
> Describes the physical state of a key which provoked the key event.
> - When a key repeats, the sequence is down -> repeat -> repeat -> up.
> </description>
> <entry name="released" value="0" summary="key is not pressed"/>
> <entry name="pressed" value="1" summary="key is pressed"/>
> - <entry name="repeat" value="2" summary="key is pressed and repeating"/>
> </enum>
>
> <event name="key">
>
I tested this on mine, as I was having issues with this, and this seems to have fixed the problems with xwayland.
More information about the wayland-devel
mailing list