Patch that "fixes" compositor-x11

[Prigent, Christophe]

Here are the result of more investigations:
- I reproduce it when launching weston from a terminal under X (and also by making weston SUID root)
- I don't reproduce it when launching weston if I 'unset DISPLAY'
- I don't reproduce it when launching weston-launch (I read here http://wayland.freedesktop.org/building.html (section: Weston and demo applications) that it only works outside of X)

Is there something wrong with the connection with x server?


-----Original Message-----
From: wayland-devel-bounces+christophe.prigent=intel.com at lists.freedesktop.org [mailto:wayland-devel-bounces+christophe.prigent=intel.com at lists.freedesktop.org] On Behalf Of Prigent, Christophe
Sent: Tuesday, June 05, 2012 10:40 AM
To: Bill Spitzak; wayland
Subject: RE: Patch that "fixes" compositor-x11

Hello,

I'm also having the problem.

I'm using Ubuntu 11.04. My computer is quite powerful (Intel core i5, 4GiB memory, graphic card: Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller)

-----Original Message-----
From: wayland-devel-bounces+christophe.prigent=intel.com at lists.freedesktop.org [mailto:wayland-devel-bounces+christophe.prigent=intel.com at lists.freedesktop.org] On Behalf Of Bill Spitzak
Sent: Monday, June 04, 2012 10:38 PM
To: wayland
Subject: Re: Patch that "fixes" compositor-x11

Any comments or insight on this problem?

I'm wondering if the slowness of compositor-x11 is a problem that only I am encountering? If everybody else is using much faster machines perhaps they won't see it, though I think if you run enough clients it should be obvious on any machine. Is there something wrong with my version of X or xcb? (I am using a stock 11.4 Ubuntu).

I would be concerned that this bug may lead to developers accidentally writing code that assumes the "deferred" calls are done after each event, rather than after blocks of events.

I have tried equivalent printf statements at other points in the code, such as in weston/client/window.c event loop, and they did not fix the speed problems. Therefore it appears the print statements must be before
  whatever is done after x11_compositor_handle_event() returns.

As accurately as I can describe what I am seeing:

  In my current version of weston compositor-x11, the static function
x11_compositor_next_event() always returns NULL after it returns non-null when it is called by x11_compositor_handle_event(). It will do this even if there are hundreds of X events queued up from moving the mouse.

  Adding an apparently-useless print statment, *after* the test, causes
x11_compositor_next_event() to return non-null more than once (up to 15 in my tests).

  The print statement must be "complex", possibly the requirement is that it causes scrolling in the gnome terminal I am sending stdout to.

  Moving the print statement to other apparently-equivalent places in the code, in particular to weston/client/window.c, does not fix the problem.
_______________________________________________
wayland-devel mailing list
wayland-devel at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

_______________________________________________
wayland-devel mailing list
wayland-devel at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.