[PATCH 0/15] Modifier fixups (especially for nested)

Kristian Høgsberg hoegsberg at gmail.com
Fri Jun 22 13:13:14 PDT 2012


On Fri, Jun 22, 2012 at 03:47:55PM -0400, Kristian Høgsberg wrote:
> On Fri, Jun 22, 2012 at 03:02:03PM -0400, Kristian Høgsberg wrote:
> > On Fri, Jun 22, 2012 at 01:21:25PM +0100, Daniel Stone wrote:
> > > Hi,
> > > The following series makes nested compositors in particular track their
> > > parent server's state more aggressively.  The main highlight is probably
> > > that the stuck modifiers bug under X11 should be completely gone, as
> > > well as enabling key bindings under GNOME Shell and other compositors
> > > that grab modifiers.
> > > 
> > > The X11 integration works best if you have a fixed XCB, i.e. xcbproto
> > > and libxcb from git from today, with XKB explicitly enabled.  However,
> > > I've done what I could for the non-XKB case and it seems to work just
> > > fine.
> > 
> > Thanks, all applied.  I fixed a typo in wayland where you send out the
> > modifier event through the pointer resource.  Also I added a commit to
> > send out the modifier event to the pointer focus if it's different
> > from keyboard focus.  I believe that with this we now send out the
> > modifier event in all the right places.
> > 
> > Under X the stuck modifer problem is gone (yay!), but without XKB
> > support, my Alt now doesn't work.  Ctrl, Shift, Super etc does, which
> > is a little odd... this fixes it:
> 
> I just tried it with xcb master and the stuck modifier is gone, but if
> I alt-tab away and then back to weston, alt just doesn't work.  It
> doesn't trigger modifier events, it just sends the regular key event.

Sorry about that, didn't have xcb-xkb enabled (didn't realize I had to
explicitly enable it in xcb).  With the xkb event it works fine.  And
I guess the above is another hint to what might broken: initially Alt
works, but Alt-tabbing away breaks it so that Alt never triggers
again... so it's the opposite of what we had before...

Kristian


More information about the wayland-devel mailing list