[PATCH 1/2] shell: Add implementation of fullscreen.

[Scott Moreau]

Hi. This patch introduces a bug where the window jumps all over the place
when resizing it. I've tracked down the problem to the following code
though I'm not sure I understand what it's meant to do yet exactly, so I
figured I'd post a comment here.


+       case SHELL_SURFACE_TOPLEVEL:
> +               if (prev_surface_type != SHELL_SURFACE_TOPLEVEL) {
> +                       if (shsurf->saved_position_valid &&
> +                           shsurf->saved_x != surface->geometry.x &&
> +                           shsurf->saved_y != surface->geometry.y) {
> +                               weston_surface_set_position(surface,
> +
> shsurf->saved_x,
> +
> shsurf->saved_y);
> +                       } else if (!shsurf->saved_position_valid) {
> +                               weston_surface_set_position(surface, 10 +
> random() % 400,
> +                                                           10 + random()
> % 400);
> +                       }
> +               }
> +               break;
>



Thanks,

Scott
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20120301/f5569310/attachment.html>