[PATCH] compositor-drm: fix libbacklight build

Kristian Hoegsberg hoegsberg at gmail.com
Sun Mar 4 19:05:05 PST 2012


On Fri, Mar 02, 2012 at 05:52:25PM +0200, Pekka Paalanen wrote:
> On Fri, 02 Mar 2012 17:37:53 +0200
> Tiago Vignatti <tiago.vignatti at linux.intel.com> wrote:
> 
> > On 03/02/2012 05:33 PM, Pekka Paalanen wrote:
> > > Bad inclusion of DRM headers, missing some system headers.
> > >
> > 
> > thanks, Pekka. I had that in my branch already. Will be sending all 
> > together to Kristian next:
> > 
> > http://cgit.freedesktop.org/~vignatti/weston/commit/?h=light-misc&id=9045af0933673b989c0f7afa9bd90cbabd4b37cd
> 
> That particular commit is not fixing the build failure, though, which
> is the DRM header.
> - drm/drm_mode.h is not part of any 'pkg-config --cflags libdrm' paths
>   on Gentoo
> - drm_mode.h should not be included directly, it depends on includes in
>   drm.h

I ended up picking up Pekkas patch now and fixing the same two
warnings Tiago fixed.  There's no reason to pend compile fixes on
further work, let's just fix it now.

Kristian


More information about the wayland-devel mailing list