[RFC] compositor: Simple key repeat implementation.

Michael Hasselmann michaelh at openismus.com
Thu Mar 8 02:38:28 PST 2012


On Wed, 2012-03-07 at 15:35 -0700, Scott Moreau wrote:
> 
> 
> On Wed, Mar 7, 2012 at 3:27 PM, Daniel Stone <daniel at fooishbar.org>
> wrote:
>         Hi,
>         
>         On 7 March 2012 22:21, Scott Moreau <oreaus at gmail.com> wrote:
>         > There's nothing fancy about this, we just set a timer and
>         simulate
>         > events using states 2 and 3 for repeat-up and repeat-down
>         events.
>         
>         
>         Did you think about just using a single event, rather than the
>         separate repeat press/release events? If nothing else, it
>         saves
>         clients the hassle of processing two events they know are
>         always
>         guaranteed to immediately follow each other ...
>         
>         Cheers,
>         Daniel
> 
> 
> If it doesn't cause a problem, we can do whatever is best. After all,
> it's a single line change here.

The difference is that press-press-press-release is detectable as
auto-repeat by the client, whereas
press-release-press-release-press-release is not. Toolkits might need
that information.

regards,
Michael



More information about the wayland-devel mailing list