[PULL wayland 0.85] signedness fixes and OS compatibility

Pekka Paalanen ppaalanen at gmail.com
Fri Mar 23 06:44:37 PDT 2012

Hi Kristian,

this patch series is divided in two:

The first part just enables compiler warnings, and then fixes or
silences them. One warning is left unfixed:
data-device.c:237:26: warning: comparison between signed and unsigned integer expressions
The fix for that would be

@@ -152,7 +152,7 @@ struct wl_grab_interface {
 	void (*motion)(struct wl_grab *grab,
 		       uint32_t time, int32_t x, int32_t y);
 	void (*button)(struct wl_grab *grab,
-		       uint32_t time, int32_t button, int32_t state);
+		       uint32_t time, uint32_t button, int32_t state);

with all the follow-up fixes, but I'm not sure you want that in 0.85,
since it changes API.

The second part is adding compatibility wrappers for non-gnu/linux or
otherwise crippled operating systems. All the wrappers should compile
to the exact same code as before on our usual gnu/linux systems.
Overhead is added only if the needed features are not supported.

There is also a bug fix as the last patch.

If this series is acceptable, I will port it to wayland master branch,

The following changes since commit 28e3cbc654a81c35a2948af93d6e86911159a13f:

  Release 0.85.0 (2012-02-09 13:15:35 -0500)

are available in the git repository at:
  git://git.collabora.co.uk/git/user/pq/wayland.git for-0.85

Pekka Paalanen (12):
      configure: add -Wextra -Wno-unused-parameter
      server: fix signedness in wl_client_connection_data
      shm: fix cosmetic gcc warnings
      scanner: fix a signedness warning
      Fix harmless signedness warnings
      connection: fix signedness warnings
      os: wrap socket(SOCK_CLOEXEC) calls
      os: wrap F_DUPFD_CLOEXEC
      os: wrap recvmsg(MSG_CMSG_CLOEXEC)
      os: wrap accept4(SOCK_CLOEXEC)
      os: wrap epoll_create
      server: do not create wl_client if accept() failed

Peter Hutterer (1):
      scanner: Remove unused variable 'len'

 configure.ac         |    2 +-
 src/Makefile.am      |    2 +
 src/connection.c     |   11 ++--
 src/event-loop.c     |    3 +-
 src/scanner.c        |    5 +-
 src/wayland-client.c |    7 +-
 src/wayland-os.h     |  154 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/wayland-server.c |   22 +++----
 src/wayland-shm.c    |    6 +-
 src/wayland-util.c   |    2 +-
 10 files changed, 185 insertions(+), 29 deletions(-)
 create mode 100644 src/wayland-os.h


More information about the wayland-devel mailing list