[PATCH 0/8] surface_attach() vfuncs

Ander Conselvan de Oliveira ander.conselvan.de.oliveira at intel.com
Wed Mar 28 08:25:26 PDT 2012

On 03/27/2012 08:39 PM, Pekka Paalanen wrote:
> On Tue, 27 Mar 2012 17:36:34 +0300
> Ander Conselvan de Oliveira<ander.conselvan.de.oliveira at intel.com>  wrote:
>> wayland changes:
>> Ander Conselvan de Oliveira (1):
>>    data-device: notify the compositor about new drag icons
>> weston changes:
>> Ander Conselvan de Oliveira (7):
>>    compositor: add a weston_surface_is_mapped() helper
>>    compositor: add weston_surface_to_global_float helper
>>    compositor: make es->pitch consistent between shm and drm
>> surfaces compositor: use new drag icon listener for setting up
>> drag surfaces compositor: refactor surface_attach()
>>    compositor: make surface_configure() a vfunc
>>    compositor: move force_configure field to shell_surface


> The error messages in patch 7 could be more user friendly,
> telling what happened in the protocol point of view. People
> reading the error message probably do not know what
> surface->configure is.

We also need to introduce an appropriate error code for this instead of 
abusing display::invalid_object. But since Kristian already pushed this, 
that will have to go on a follow-up patch.

Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the wayland-devel mailing list