[PATCH 1/4] Port Wayland clients to new xkbcommon API

Bill Spitzak spitzak at gmail.com
Mon May 7 16:30:05 PDT 2012

Kristian Høgsberg wrote:

> The original code tests that shift and control are
> pressed, but it really should test modifers == SHIFT | CONTROL, that
> is, that those and *only* those modifiers are down.

Watch out that this is only testing what the user thinks of as 
modifiers. I did this and was burned by programs that failed if 
capslock, numlock, or scrolllock was down.

Though of course Wayland (and maybe XKB) can avoid this by making sure 
things that are not what the user considers transient modifiers are just 
  not there, so zero means what you expect.

More information about the wayland-devel mailing list