[PATCH 1/2] server: Initialise serial number counter for wl_display

Kristian Høgsberg hoegsberg at gmail.com
Tue May 22 12:52:32 PDT 2012


On Tue, May 22, 2012 at 06:48:13PM +0100, Rob Bradford wrote:
> From: Rob Bradford <rob at linux.intel.com>

Thanks, this and 2/2 applied.
Kristian

> This ends up propagating through and creating a valgrind error like:
> 
> ==22573== Conditional jump or move depends on uninitialised value(s)
> ==22573==    at 0x409E57: pointer_attach (compositor.c:1999)
> ==22573==    by 0x34ECE05D63: ffi_call_unix64 (unix64.S:75)
> ==22573==    by 0x34ECE05784: ffi_call (ffi64.c:486)
> ==22573==    by 0x5674C45: wl_closure_invoke (connection.c:770)
> ==22573==    by 0x566ECCB: wl_client_connection_data (wayland-server.c:255)
> ==22573==    by 0x56722F1: wl_event_source_fd_dispatch (event-loop.c:79)
> ==22573==    by 0x5672C91: wl_event_loop_dispatch (event-loop.c:410)
> ==22573==    by 0x56705F4: wl_display_run (wayland-server.c:1003)
> ==22573==    by 0x40C775: main (compositor.c:2937)
> ---
>  src/wayland-server.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/wayland-server.c b/src/wayland-server.c
> index c1be56a..6ccc097 100644
> --- a/src/wayland-server.c
> +++ b/src/wayland-server.c
> @@ -895,6 +895,7 @@ wl_display_create(void)
>  	wl_list_init(&display->client_list);
>  
>  	display->id = 1;
> +	display->serial = 0;
>  
>  	if (!wl_display_add_global(display, &wl_display_interface, 
>  				   display, bind_display)) {
> -- 
> 1.7.7.6
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list