[PATCH] compositor: Fix buggy snprintf that sets module path

[Kristian Høgsberg]

On Tue, May 29, 2012 at 12:29 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/25/2012 08:04 PM, Kristian Høgsberg wrote:
>> On Wed, May 23, 2012 at 11:32:24PM -0700, Chad Versace wrote:
>>> If the MODULEDIR string contains '%', then
>>>     snprintf(path, sizeof(path), MODULEDIR "/%s", name);
>>> does not do what you want.
>>
>> Heh, 'buggy' is a little harsh..
>> [...] unless you say ./configure --libdir='lulz%n%n',
>> there's no problem.
>>
>> Kristian
>
> I wasn't concerned with security. Weston failed to start for me
> because I configured with --libdir="~/graphics/%master/...".

Ok, point taken.  That's certainly a valid (if a bit unusual) use case.
Kristian

> - ----
> Chad Versace
> chad.versace at linux.intel.com
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.19 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQIcBAEBAgAGBQJPxPl9AAoJEAIvNt057x8iFPcP/3QLI1fYzWQB/cG1F01Nbz1d
> C6snciUJRFe27xZr/M83yudwtgI7KTyTCo9NFrdL5aQ6HWMZLm9o/yzesyPtfhl7
> F6CCdLQJ21We6u3GE6NjIlHCx+F8La4ceLrfxzHX70vTKzI2aqL1uQq1QMzLiSi6
> W1ZnnvPIwPxTAKyqqDruyLq1fqwdMFSbFtODHwXO+372T70mA4aldpF6Es+LF1l6
> F++OjY9yGeZiPmONz0kKcqovlD2zQqVkE3R148FDeVca2LB6rxYtdH52qC3DLE8D
> U82ha2IuwHuntbQYQaSLeYNnhu6c46UinA5OzjPrCILq9vML6u9E4mH/U7DbrYk7
> SaEtWTmA+0s6inXSzFQ1xIDvb/UFori8YwGfaiLzMoJ6Xbmm8ikJmrUwnC79dqnc
> L9HvYrBO//MLe2eT3Bq292BFc9oo32H524iQiaNG0TpQFob85+sNXEJ5AtVmfMKV
> UdHSir7Xak0StHlw1C7QVYPZhPr1eNWkGthoc/H8zIJrUF7Ykn3uoRNj/apdGqZa
> EOaoEc0y2t4aBmuxX75+1XIDcX3mmNRXUoVtaQaB9NWUG+TOoYxZh7+E2GPWf5M6
> WTwTFVxeGVPTmYjroAy3jIjFxXF92QgihD2IXfzgypdMYdyN2+2Eor/dcHWqjJ14
> XwJxlC7e3EOgLyvdJnX/
> =YWCx
> -----END PGP SIGNATURE-----