[PATCH weston 30/31] Add weston_compositor::input_init

Daniel Stone daniel at fooishbar.org
Thu May 31 14:23:55 PDT 2012


Hi,

On 31 May 2012 21:58, Kristian Høgsberg <hoegsberg at gmail.com> wrote:
> On Wed, May 30, 2012 at 04:32:08PM +0100, Daniel Stone wrote:
>> This function gets called after backend_init, so compositors can add
>> their input devices slightly later on in the process.  This gives us a
>> chance to set the default XKB rulesets, in particular.
>
> I don't like input_init.  The startup sequence is already getting
> quirky and I don't want another callback in there.  We can set up the
> default XKB map in weston_compositor_init() and avoid this.  Or maybe
> the xkb rules in weston.ini should be a compositor-drm only thing.
> Other backends get it from their host, and compositor-drm can read it
> from weston.ini.

Yeah, fair enough, no objections here.  The following patches rejig it
so all the hosted compositors try to build a keymap themselves and
only ever use the weston.ini rules as a default, which I think makes
sense.

I'll redo this one so it just moves weston_compositor_init before any
input device creation and calls it from there.

Thanks!

-d


More information about the wayland-devel mailing list