[PATCH weston 1/6] window: make display_create_surface() shm-only

[Pekka Paalanen]

On Tue, 27 Nov 2012 16:05:13 -0500
Kristian Høgsberg <hoegsberg at gmail.com> wrote:

> On Mon, Nov 19, 2012 at 05:15:57PM +0200, Pekka Paalanen wrote:
> > Nothing uses it to create EGL-surfaces outside of window.c. This makes
> > refactoring the EGL-based code easier, since we do not need to support
> > EGL-based Cairo surfaces without an associated struct window.
> 
> This entire series applied now.  I had a few nitpick comments to some
> of the patches but they're all applied.  I don't like the struct
> toysurface name, I think it should just be struct surface, since
> everything else in toytoolkit is not prefixed.  Of we should go in the
> other direction and prefix everything, which may be long overdue
> anyway.  Currently it's hard to tell toytoolkit code from sample
> client code.  How about we just call it weston toolkit and prefix it
> all wtk?
> 
>   d = wtk_display_create();
> 
>   wtk_window_destroy(win);
> 
> etc... and rename window.[ch] to wtk.[ch] Or maybe we want to split it
> into wtk-display.c, wtk-window.c, wtk-surface-egl.c etc...

Hi Kristian,

thanks for the review. I can look into renaming and splitting for now,
and address the minor concerns, too.

- pq