[PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

[Ran Benita]

On Thu, Oct 04, 2012 at 04:58:50PM +0200, David Herrmann wrote:
> Hi Ran
> 
> On Wed, Oct 3, 2012 at 10:18 AM, Ran Benita <ran234 at gmail.com> wrote:
> 
> [snip]
> 
> > So since makekeys is ugly and gperf is a bit excessive, maybe we should
> > just keep it simple, what do you think?
> 
> Indeed. Thanks a lot for reviewing though. Just some comments on your
> patch below:
> 
> > From 8fb5efb045b7207b010c979cbeae8f8222759961 Mon Sep 17 00:00:00 2001
> > From: Ran Benita <ran234 at gmail.com>
> > Date: Wed, 3 Oct 2012 10:09:48 +0200
> > Subject: [PATCH libxkbcommon] Replace makekeys with python script + binary
> >  search
> 
> Great empty commit-message ;) Maybe mention that we used to have a
> home-brew hash-table (old makekeys) and gperf is not worth it as it
> generates huge tables. So we just go with bsearch here. If anyone
> wants to change that, they should provide proper benchmarks first.

Oh, I didn't intend it to be merged, it was just to test the concept. I
was actually hoping you would write it properly :)
Also I think there might be a bug in the python script I did, unless
"sorted()" always keeps entries with the same keys in their original
order.

Ran