[PATCH weston 7/7] configure: build tablet-shell client conditionally

Pekka Paalanen ppaalanen at gmail.com
Tue Oct 16 09:52:13 PDT 2012

On Tue, 16 Oct 2012 11:11:51 -0400
Kristian Høgsberg <hoegsberg at gmail.com> wrote:

> On Tue, Oct 16, 2012 at 05:49:20PM +0300, Tiago Vignatti wrote:
> > On 10/16/2012 05:27 PM, Pekka Paalanen wrote:
> > >Do not build the tablet-shell client if --disable-tablet-shell is given.
> > 
> > hmm, why actually? It doesn't take long to compile and it's a good
> > practice to compile the code to make sure we don't break things
> > there.
> > 
> > Note that I'm not discussing (all over again) the reasons of the
> > shells or whether they're "core" or not protocols :)
> It's still enabled by default, and I think it's fine to be able to
> disable it.

My thoughts exactly.

The tablet-shell client is useless without the tablet-shell plugin.
We still build them both by default, and if you make the extra
effort during configure to disable it, might as well not build it.
This more of a consistency fix than anything practical. The client
didn't cause me any trouble.

It was also getting installed even if you specified
--disable-tablet-shell, and that was odd.


More information about the wayland-devel mailing list