Weston under X crashes

Kristian Høgsberg hoegsberg at gmail.com
Wed Oct 24 11:43:24 PDT 2012


On Wed, Oct 24, 2012 at 9:42 AM, David Herrmann
<dh.herrmann at googlemail.com> wrote:
> Hi
>
> On Tue, Oct 23, 2012 at 7:49 PM, Kristian Høgsberg <hoegsberg at gmail.com> wrote:
>> On Tue, Oct 23, 2012 at 05:12:43PM +0100, Niklas Hambüchen wrote:
>>> Can we make X Weston test-wise draw some fancy stuff into regions it is
>>> forced to fill up in tiling WMs? That would make reproducing this a
>>> little bit easier.
>>
>> I don't really have a good suggestion there, but this patch should fix
>> it as far as I can see.
>>
>> Kristian
>>
>> From 0e6e9ca45a97b6aeadb9decd6bef6673f083e7ea Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Kristian=20H=C3=B8gsberg?= <krh at bitplanet.net>
>> Date: Tue, 23 Oct 2012 13:04:09 -0400
>> Subject: [PATCH] compositor: Clip pointer coordinates on pointer enter as
>>  well
>>
>> When tiling window managers resize a non-resizable window they're violating
>> ICCCM.  Not some hippie-community standard like EWMH, but ICCCM, which is
>> about as old and sacred as the constitution.  If they want to force a window
>> to be a size it wasn't designed for, at least they could have the decency to
>> reparent the client window into a bigger containing window of whatever size
>> they think it should be.  But apparently ICCCM compliance is too much to ask.
>>
>> Anyway, all that just to say that it's really not our fault when we get an
>> enter event with coordinates outside the valid output region.  But we'll
>> clip it anyway and work around mis-behaving tiling WMs.
>> ---
>>  src/compositor.c |    1 +
>>  1 file changed, 1 insertion(+)
>
> This fixes the crashes here on my machine with tiling-WMs.

Yup, tried it myself after installing awesome.  Committed and pushed.

Kristian


More information about the wayland-devel mailing list