compositor-android: should output be added to compositor one step before

Abhijit Potnis abhijitpotnis at gmail.com
Thu Sep 13 00:18:52 PDT 2012


Hello Pekka,

In compositor-android.c , Should we be calling
android_compositor_add_output() before gles2_renderer_init(),
or else wouldn't "op" in gles-renderer_init get assigned a junk value.

---
 src/compositor-android.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/compositor-android.c b/src/compositor-android.c
index 50c66e6..0194379 100644
--- a/src/compositor-android.c
+++ b/src/compositor-android.c
@@ -476,11 +476,11 @@ android_compositor_create(struct wl_display *display,
int argc, char *argv[],
     if (android_init_egl(compositor, output) < 0)
         goto err_output;

+    android_compositor_add_output(compositor, output);
+
     if (gles2_renderer_init(&compositor->base) < 0)
         goto err_egl;

-    android_compositor_add_output(compositor, output);
-
     compositor->seat = android_seat_create(compositor);
     if (!compositor->seat)
         goto err_egl;
-- 



-- 
Regards,
Abhijit Potnis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20120913/6607386d/attachment-0001.html>


More information about the wayland-devel mailing list