[PATCH] shell: Fix crash when an input panel is hiding

Jan Arne Petersen jpetersen at openismus.com
Fri Sep 21 05:43:55 PDT 2012


I figured out there is also another problem with the output of input
panels which will result in a crash in input_panel_configure, so I think
we better fix it properly.

On 09/19/2012 02:31 PM, Jan Arne Petersen wrote:
> From: Jan Arne Petersen <jpetersen at openismus.com>
> 
> Do not call weston_slide_run when the surface's output is NULL.
> ---
>  src/shell.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/shell.c b/src/shell.c
> index 2afa1b3..8dc6f50 100644
> --- a/src/shell.c
> +++ b/src/shell.c
> @@ -2765,7 +2765,8 @@ show_input_panels(struct wl_listener *listener, void *data)
>  			       &ws->layer_link);
>  		weston_surface_update_transform(ws);
>  		weston_surface_damage(ws);
> -		weston_slide_run(ws, ws->geometry.height, 0, NULL, NULL);
> +		if (ws->output)
> +			weston_slide_run(ws, ws->geometry.height, 0, NULL, NULL);
>  	}
>  }
>  
> 



More information about the wayland-devel mailing list