[PATCH weston] compositor: Load shell plugin after option modules

Kristian Høgsberg hoegsberg at gmail.com
Tue Sep 25 08:19:35 PDT 2012

On Tue, Sep 25, 2012 at 05:54:40PM +0300, Tiago Vignatti wrote:
> On 09/25/2012 05:13 PM, Kristian Høgsberg wrote:
> >On Tue, Sep 25, 2012 at 01:52:43PM +0300, Tiago Vignatti wrote:
> >>It's a quick fix in opposition of the lack of the two-stage module init.
> >>Effectively it fix:
> >>
> >>     https://bugs.freedesktop.org/show_bug.cgi?id=55259
> >
> >No, the command line modules are supposed to load after the config
> >file modules.  I think the fix we're looking for is to just start the
> >desktop-shell client in an idle handler, ie use
> >wl_event_loop_add_idle() to install a handler that will be called once
> >the event loop is running and call launch_desktop_shell_process() from
> >there.
> cool, that should work. I'm sending the patch next.
> BTW (a bit related with this) to solve part of the Bug 53679, the
> way we're using socketpair_cloexec to create the client socket and
> later get its credentials in wl_client_create is wrong; clients end
> up with the same pid, uid, etc as the compositor instead.
> Specifically xwayland and weston-desktop-shell are getting the wrong
> values.

Oh, because we're still holding both ends when we create the client?
Hehe, that's wonderful, nice find :) Hmm... do the credentials change
after fork or after we close the socket in the parent...  I'm not sure
how things are supposed to work in that case, should be interesting to
find out.


More information about the wayland-devel mailing list