[PATCH v3] shell: Fix crash when an input panel is hiding

Kristian Høgsberg hoegsberg at gmail.com
Wed Sep 26 08:35:00 PDT 2012


On Wed, Sep 26, 2012 at 02:39:45PM +0200, Jan Arne Petersen wrote:
> From: Jan Arne Petersen <jpetersen at openismus.com>
> 
> Set the geometry.dirty on the input panel surface before calling
> weston_surface_update_transform, so that the surface gets an output
> assigned.

Ah, that looks like the right fix.  I think we should set
geometry.dirty in weston_surface_unmap() though.

Kristian

> ---
>  src/shell.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/shell.c b/src/shell.c
> index 2afa1b3..e2715d6 100644
> --- a/src/shell.c
> +++ b/src/shell.c
> @@ -2763,6 +2763,7 @@ show_input_panels(struct wl_listener *listener, void *data)
>  		ws = surface->surface;
>  		wl_list_insert(&shell->input_panel_layer.surface_list,
>  			       &ws->layer_link);
> +		ws->geometry.dirty = 1;
>  		weston_surface_update_transform(ws);
>  		weston_surface_damage(ws);
>  		weston_slide_run(ws, ws->geometry.height, 0, NULL, NULL);
> -- 
> 1.7.11.4
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list