[PATCH v2] event-test: more aggressive event testing

Eoff, Ullysses A ullysses.a.eoff at intel.com
Fri Sep 28 06:08:12 PDT 2012


>-----Original Message-----
>From: David Herrmann [mailto:dh.herrmann at googlemail.com]
>Sent: Thursday, September 27, 2012 11:31 PM
>To: Eoff, Ullysses A
>Cc: wayland-devel at lists.freedesktop.org
>Subject: Re: [PATCH v2] event-test: more aggressive event testing
>
>Hi
>
>On Thu, Sep 27, 2012 at 11:34 PM, Eoff, Ullysses A
><ullysses.a.eoff at intel.com> wrote:
>> It was pointed out to me that I used C++ style comments... whoops, old
>habits.
>>
>> Before I resubmit does anyone else see any other coding convention issues
>that I missed or deviated from?  Kristian?
>
>Following kernel CodingStyle is probably the best you can do. There is
>little that we do different. Besides c++ style comments, your patches
>look fine. But I think we indent multi-line function-calls with the
>first function-argument.
>
>But the common rules apply: look at the 100 lines above and below your
>code and follow this style.
>
>Regards
>David

Thanks for the good feedback :)

U. Artie


More information about the wayland-devel mailing list