[PATCH] Correctly handle extended RDP keycodes

[Ran Benita]

On Sat, Apr 06, 2013 at 11:39:26PM +0200, Hardening wrote:
> The keycodes received by the FreeRDP server aren't evdev keycodes.
> This patch adds the correct convertion to evdev keycodes. After the
> patch all keys that are marked as extended in RDP packets become
> functionnal (that's the case for the windows key).
> Please note that this patch rely on some corrections that have been
> pushed on the FreeRDP github tonight.
> ---
>  src/compositor-rdp.c |   54 +++++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 42 insertions(+), 12 deletions(-)

Hi,

Your approach is almost certainly the best approach. I'll just like to
mention for the archive: the underlying keymap library (libxkbcommon)
actually has a keycode abstraction, i.e. you can map them however you
want with a "keycodes" file (e.g. /usr/share/X11/xkb/keycodes/evdev -
note that with xkbcommon there is no limit to the number of keycodes or
the length of their names). So if you have a say in the XKB keymap that
is used (as the compositor does afaik), you can do it like that. But
again just translating to evdev is probably the easiest and least
confusing way to do it.

Ran