[PATCH 2/3] Add a 'serial' property on weston_output

[Emilio Pozuelo Monfort]

On 04/23/2013 05:37 PM, Rob Bradford wrote:
> On Mon, Apr 22, 2013 at 12:57:03PM +0100, Richard Hughes wrote:
>> ---
>>  src/compositor-drm.c | 1 +
>>  src/compositor.h     | 2 +-
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/compositor-drm.c b/src/compositor-drm.c
>> index 61ef97e..a454676 100644
>> --- a/src/compositor-drm.c
>> +++ b/src/compositor-drm.c
>> @@ -1522,6 +1522,7 @@ create_output_for_connector(struct drm_compositor *ec,
>>   output->base.subpixel = drm_subpixel_to_wayland(connector->subpixel);
>>   output->base.make = "unknown";
>>   output->base.model = "unknown";
>> + output->base.serial = "unknown";
>>   wl_list_init(&output->base.mode_list);
>>
>>   if (connector->connector_type < ARRAY_LENGTH(connector_type_names))
>> diff --git a/src/compositor.h b/src/compositor.h
>> index 1e999a6..fa6162c 100644
>> --- a/src/compositor.h
>> +++ b/src/compositor.h
>> @@ -178,7 +178,7 @@ struct weston_output {
>>   uint32_t frame_time;
>>   int disable_planes;
>>
>> - char *make, *model;
>> + char *make, *model, *serial;
>>   uint32_t subpixel;
>>   uint32_t transform;
> 
> Hi Richard,
> 
> When I read the commit message I wondered "why does he need a serial"
> for the wl_output. I was of course thinking about the wayland use of
> "serial" as a sequence number.
> 
> Are you intending to expose this through the wayland protocol? If so
> have you considered how this ambiguity might be avoided.

This is exposed in the weston SDK (compositor.h is a public header). This patch
breaks the ABI, but I don't think we have promised to keep it stable for now.

Regards,
Emilio