[PATCH v2 wayland] pkg-config: scanner isn't arch-independent

[David Herrmann]

Hi

On Fri, Aug 16, 2013 at 2:26 PM, Daniel Stone <daniel at fooishbar.org> wrote:
> $(datadir) rather than $(libdir), is for architecture-independent data.
> pkg-config files should only be installed there if they're shareable
> across architectures, e.g. headers/data only, which wayland-scanner is
> not.  Move it to $(libdir) with the other pkg-config files.
>
> Signed-off-by: Daniel Stone <daniel at fooishbar.org>
> ---
>
> v2: Oops, wasn't looking when I pulled this over from my other tree.
>     Fix = vs. +=.
>
>  src/Makefile.am | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 4226f63..efdfaf4 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -58,8 +58,7 @@ wayland_scanner_LDADD = $(EXPAT_LIBS) libwayland-util.la
>
>  $(BUILT_SOURCES) : wayland-scanner
>
> -scannerpkgconfigdir = $(datadir)/pkgconfig
> -scannerpkgconfig_DATA = wayland-scanner.pc
> +pkgconfig_DATA += wayland-scanner.pc

Yepp, we should definitely use pkgconfig_DATA.
Reviewed-by: David Herrmann <dh.herrmann at gmail.com>

Cheers
David

>  endif
>
>  BUILT_SOURCES =                                        \
> --
> 1.8.3.1
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel