[PATCH v4] Fixes CJK wide character display

[Othman, Ossama]

Hi,

CCing the list this time around ...

On Sun, Aug 18, 2013 at 7:59 PM, Peng Wu <peng.e.wu at gmail.com> wrote:

> By jumping two columns when wide character prints,
> and draw wide background under wide character.
> ---
>  clients/terminal.c | 31 +++++++++++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)
>
> diff --git a/clients/terminal.c b/clients/terminal.c
> index 6701fb6..9da1a56 100644
> --- a/clients/terminal.c
> +++ b/clients/terminal.c
> @@ -33,6 +33,9 @@
>  #include <ctype.h>
>  #include <cairo.h>
>  #include <sys/epoll.h>
> +#define __USE_XOPEN
> +#include <wchar.h>
> +#include <locale.h>
>

That's an implementation-specific preprocessor symbol.  Please use the
_XOPEN_SOURCE feature test macro instead.

The user could also potentially define that feature test macro with a
specific value, such as 500 (see
http://pubs.opengroup.org/onlinepubs/7908799/xsh/compilation.html), in
CPPFLAGS via the configure script as well, meaning it would be good to
check if _XOPEN_SOURCE is defined before explicitly defining it.

HTH,
-Ossama
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130819/6dd55d6f/attachment.html>