[PATCH wayland-web] building: Recommend disabling setuid for non-root installs

[David Herrmann]

Hi

On Sun, Aug 25, 2013 at 9:57 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Fri, 23 Aug 2013 19:54:17 +0000
> "Bryce W. Harrington" <b.harrington at samsung.com> wrote:
>
>> The build directions guide the user to build and install Wayland in a
>> user directory without using superuser privs.  However, the weston build
>> process includes a `chown root` on weston-launcher done by default,
>> which results in a failed build when running make install as
>> non-superuser, unless we pass --enable-setuid-install=no to disable the
>> feature.
>>
>> (Probably would be better to fix weston so make install works as
>> non-root, but for now just document the workaround...)
>>
>> Signed-off-by: Bryce Harrington <b.harrington at samsung.com>
>> ---
>>  building.html |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/building.html b/building.html
>> index b7a1158..a47744e 100644
>> --- a/building.html
>> +++ b/building.html
>> @@ -228,7 +228,7 @@ gio-2.0.</p>
>>
>>  <pre>    $ git clone git://anongit.freedesktop.org/wayland/weston
>>      $ cd weston
>> -    $ ./autogen.sh --prefix=$WLD
>> +    $ ./autogen.sh --prefix=$WLD --enable-setuid-install=no
>>      $ make
>>      $ make install
>>  </pre>
>
> I believe setuid weston-launch is mandatory for all backends
> that use evdev, that is at least drm and fbdev. Otherwise they
> cannot open input devices on normal system setups.
>
> Maybe prefer 'sudo make install' then?

It is also mandatory for DRM (see drmSetMaster()). So I'd recommend "sudo", too.

Cheers
David