[RFC] compositor-drm: Add hardware accelerated capture of screen using libva

[Daniel Stone]

Hi,

On 30 August 2013 03:56,  <sardemff7+wayland at sardemff7.net> wrote:
> On 30/08/2013 06:37, Kristian Høgsberg wrote:
>> On Fri, Aug 23, 2013 at 05:15:48PM +0300, Ander Conselvan de Oliveira
>> wrote:
>>> +PKG_CHECK_MODULES(LIBVA, [libva >= 0.34.0 libva-drm >= 0.34.0],
>>> [have_libva=yes], [have_libva=no])
>>> +AS_IF([test "x$have_libva" = "xyes"],
>>> +      [AC_DEFINE([HAVE_LIBVA], [1], [Have libva])])
>>> +AM_CONDITIONAL(ENABLE_LIBVA, test "x$have_libva" = "xyes")
>
> Before merging it, this part should be modified. There are already too much
> automagic features in this configure.ac. Please add a switch to enable and
> disable this feature not based on detection. Packagers will love you.

Detection is fine, and detection by default is even fine too.  Just as
long as there are also explicit switches either way.