[PATCH 00/16] xdg-shell protocol, implementation and port of toytoolkit.

Rafael Antognolli antognolli at gmail.com
Tue Dec 3 09:42:05 PST 2013


On Fri, Nov 29, 2013 at 9:54 PM, Kristian Høgsberg <hoegsberg at gmail.com> wrote:
> On Fri, Nov 29, 2013 at 02:23:11PM -0800, Kristian Høgsberg wrote:
>> On Wed, Nov 27, 2013 at 03:50:16PM -0200, Rafael Antognolli wrote:
>> > As discussed previously, this patch series adds the xdg-shell protocol, its
>> > implementation on weston, and the client implementation on toytoolkit.
>>
>> Hi Raphael,
>>
>> I think we want to get this in early and then iterate on it in-tree
>> instead of kicking this big patch set around on the list for too long.
>> Overall it looks good, there are just a few things that I'd like to
>> fix up before we land the patches.  I'll reply and review to the
>> individual patches.
>>
>> Also, I'll try to land Philip Withnalls series from Nov 25, since it
>> looks like a nice clean up and ends up fixing a bug (always lovely).
>> It does conflict quite a bit with your shell.c patches, but it
>> shouldn't be too hard to rebase or just redo them on top.
>
> Btw, once we get the xdg-shell part of shell.c landed, I'd like to
> rename the structs to the xdg names, ie struct shell_surface becomes
> struct xdg_surface etc.

Cool, as soon as we get it merged I can work on this and your other
suggestions. I'm adding some comments on the respective patch reviews.

>> Kristian
>>
>> > Jasper St. Pierre (5):
>> >   westoy: Schedule a full resize when we add a subsurface
>> >   westoy: Use subsurfaces for tooltips instead of transient windows
>> >   westoy: Remove fullscreen methods
>> >   westoy: Remove MAXIMIZED and FULLSCREEN as separate window types
>> >   westoy: Port the toy toolkit over to xdg-shell
>> >
>> > Rafael Antognolli (11):
>> >   xdg_shell: Adding a new shell protocol.
>> >   shell: Remove SHELL_SURFACE_FULLSCREEN and SHELL_SURFACE_MAXIMIZED.
>> >   shell: Change set_maximized to receive internal structures.
>> >   xdg-shell: Implement part of the interface.
>> >   xdg-shell: Implementing maximized and fullscreen states.
>> >   xdg-shell: Implement set_transient_for request.
>> >   xdg-shell: Implement xdg_popup.
>> >   xdg-shell: Add surface size to configure.
>> >   xdg-shell: xdg_surface_set_output should only affect fullscreen.
>> >   xdg-shell: Use xdg-shell in simple-shm.
>> >   xdg-shell: Add key bindings for setting maximized and fullscreen.
>> >
>> >  clients/.gitignore     |   2 +
>> >  clients/Makefile.am    |  12 +-
>> >  clients/fullscreen.c   |  19 +-
>> >  clients/simple-shm.c   |  50 +--
>> >  clients/transformed.c  |  21 +-
>> >  clients/window.c       | 418 ++++++++++++-------------
>> >  clients/window.h       |   3 -
>> >  protocol/Makefile.am   |   3 +-
>> >  protocol/xdg-shell.xml | 438 ++++++++++++++++++++++++++
>> >  src/.gitignore         |   2 +
>> >  src/Makefile.am        |   6 +-
>> >  src/shell.c            | 829 +++++++++++++++++++++++++++++++++++++++++--------
>> >  12 files changed, 1387 insertions(+), 416 deletions(-)
>> >  create mode 100644 protocol/xdg-shell.xml
>> >
>> > --
>> > 1.8.3.1
>> >
>> > _______________________________________________
>> > wayland-devel mailing list
>> > wayland-devel at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel



-- 
Rafael Antognolli


More information about the wayland-devel mailing list