[RFC weston 0/4] Autotools cleanup & rework
hoegsberg at gmail.com
Sat Dec 7 15:11:27 PST 2013
On Fri, Dec 06, 2013 at 11:31:22PM +0100, Quentin Glidic wrote:
> From: Quentin Glidic <sardemff7+git at sardemff7.net>
> These are the first four patches I am going to send to clean the Weston
> Åutotools stuff.
> They are good to push directly, the RFC stands for the “is the overall
> design ok?” question.
> If these one are pushed, I will work on cleaning the rest of the
> configure.ac file and then the Makefile.am ones.
> I will then work on a second series to make Weston use a single Makefile,
> splitting the Makefile.am as I did for the configure.ac here.
As I wrote in the patch review, I don't see splitting configure.ac as
a win at this time. Recursive Makefiles are popular because you can
keep the Makefile.am next to the files it builds. It's of course
slower because of the multiple invocations of make, and a
non-recursive Makefile.am avoids that. A non-recursive Makefile.am
that includes Makefile.ams from its subdirectories sems like the best
of both worlds to me.
I don't see a similar win in splitting up configure.ac.
> Quentin Glidic (4):
> autotools: Use AM_DISTCHECK_CONFIGURE_FLAGS
> autotools: Search for .m4 files in m4/
> configure.ac: Split common stuff to m4/common.m4
> configure.ac: Split weston-launch stuff
> Makefile.am | 6 ++++--
> configure.ac | 56 +++--------------------------------------------------
> m4/common.m4 | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++
> m4/weston-launch.m4 | 24 +++++++++++++++++++++++
> 4 files changed, 85 insertions(+), 55 deletions(-)
> create mode 100644 m4/common.m4
> create mode 100644 m4/weston-launch.m4
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
More information about the wayland-devel