[PATCH] Fix compilation with FreeRdp 1.1 and master

Hardening rdp.effort at gmail.com
Tue Dec 10 00:25:54 PST 2013

On 10/12/2013 00:42, Kristian Høgsberg wrote:
> On Mon, Dec 09, 2013 at 10:16:39PM +0100, Hardening wrote:
>> The API to use remoteFx encoding has changed between master and stable 1.1
>> branch. This patch fixes compilation for both.
>> Please note that the freerdp/version.h file is generated in the very last versions
>> of FreeRdp so be sure to update/install the last versions.
> Yeah, this doesn't compile for me with an older FreeRdp because of the
> missing freerdp/version.h.  If we're going to require a newer FreeRdp
> for this to compile, can we just drop the #if?  Or is version.h
> included by freedrp.h or something so we can avoid the version.h
> #include?
Until recent changes there were no safe way to know which version you 
were compiling against.
The FREERDP_VERSION_[MAJOR|MINOR|REVISION] macros have never been 
accurate to detect this (not updated when they should). These macros 
were included in the freerdp/freerdp.h and are now auto-generated in the 
freerdp/version.h file.

You're right i think i can have a better patch that will take care of 
the installation that are missing the freerdp/version.h file.


More information about the wayland-devel mailing list