[PATCH weston 03/11] configure.ac: Correctly check for functions and libraries

[Quentin Glidic]

On 10/12/2013 10:57, Ander Conselvan de Oliveira wrote:
> On 12/09/2013 12:44 PM, Quentin Glidic wrote:
>> On 09/12/2013 11:28, Ander Conselvan de Oliveira wrote:
>> I am trusting the Autoconf manual[1] on this one. Basically, the
>> double-check we are doing for dlopen is exactly what AC_SEARCH_LIBS is
>> done for: checking in both a library and in libC.
>
> That is the kind of information I would like to see in the commit
> message if I stumble upon this 6 months from now. No need to dig through
> the Autoconf manual. :)

You should have already read the whole manual, twice. The only reason 
people hate Autotools so much is that they do not read the manual and 
expect them to automagically get what they mean. :-)

New patch sent as a reply to this one. It breaks the series but I will 
send back the full series once all comments are addressed.


>>> Anyway, this seems like a change for the worse IMO.
>>
>> Following Autotools best practices/manual is *never* worse.
>>
>>> Now you're typing jpeg_CreateDecompress three times instead of just
>>> one.
>>
>> 8 lines for the new version vs 7 lines for the old one…
>
> My point was that having to type the same thing three times is error
> prone, and the copy & paste error above kind of proves my point. Anyway,
> if we can turn this into a one line macro that would be much better.
>
>>> Ideally this could be just a one-liner, since this construct has to be
>>> repeated a few times.
>>
>> It is easy enough to create a macro to do the check. If so, do we want
>> the error message to be accurate (e.g. Weston vs clients vs
>> weston-launch)?
>
> I think it would be good, if it's just a matter of adding one more
> parameter.

Introduced WS_SEARCH_LIBS in the new version of this patch.


>> [1]
>> http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf.html#Libraries



-- 

Quentin “Sardem FF7” Glidic