[PATCH weston 07/11] configure.ac: m4-quote AM_CONDITIONAL tests

Quentin Glidic sardemff7+wayland at sardemff7.net
Tue Dec 17 04:33:00 PST 2013

On 17/12/2013 02:03, Kristian Høgsberg wrote:
> This currently works as is... why add more quoting?

m4-quoting and m4-expansion are tricky and it is considered as a good 
practice to quote a bit (read “almost everything”), afaict.

I do not mind not quoting here (AM_CONDITIONAL) since these part are 
less likely to break in the future (being shell code).

For the AC_PATH_PROG and AC_ARG_VAR patch, I do think quoting is a good 
thing since it is pure m4 code and using quite common names (someone 
could have "XMLLINT" as a local macro to search for xmllint to use it in 
a project).


Quentin “Sardem FF7” Glidic

More information about the wayland-devel mailing list