[PATCH v2 2/2] x11 backend: add option to use pixman renderer

[Pekka Paalanen]

On Mon, 7 Jan 2013 13:49:38 -0500
Kristian Høgsberg <hoegsberg at gmail.com> wrote:

> On Mon, Jan 07, 2013 at 08:39:50PM +0300, Vasily Khoruzhick wrote:
> > When --use-shm is passed to weston and x11 backend is active,
> > it will use SHM surfaces with pixman renderer instead of EGL
> > 
> > Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>
> > ---
> > v2: - handle missing MIT-SHM extension gracefully (tested with Xnest)
> >     - follow libc convention of error handling
> >     - get rid of xcb-aux dependency
> 
> Looks good, committed.  Is there a reason you don't just use
> visual_type->depth instead of get_depth_of_visual()?  Maybe I'm
> missing something.  Also, to test the pixman renderer with desktop
> shell, I have to comment out
> 
> #define HAVE_CAIRO_EGL 1
> 
> in config.h, since we don't have a configure option to disable that.
> If you feel like making a patch to add --disable-egl or such, that
> would be great.  And of course, it would be nice to make the
> pixman-renderer work with the kms backend.

Actually, we do have a trick to achieve that, but it's non-obvious.

Cairo can be built with either GL or GLES, not both (last I looked),
which means either cairo-gl or cairo-glesv2 pkg-config is not
available. Then just use one of --with{,out}-cairo-glesv2 to hit the
non-existant case, and cairo-egl gets disabled.

But yeah, that is just a lame trick.

I see the toytoolkit was already fixed to fall back to cairo-image. :-)

Excellent to see these land!


Thanks,
pq