[PATCH 3/3] Make EGL/GLESv2 dependencies optional

Vasily Khoruzhick anarsoul at gmail.com
Wed Jan 9 01:44:54 PST 2013


On Wed, Jan 9, 2013 at 12:03 AM, Vasily Khoruzhick <anarsoul at gmail.com> wrote:
> On Wed, Jan 9, 2013 at 12:01 AM, John Kåre Alsaker
> <john.kare.alsaker at gmail.com> wrote:
>> EGLDisplay, EGLSurface, EGLNativeDisplayType and EGLNativeWindowType
>> should all be void *. With that change you can get rid of the ugly
>> typecasts.

xcb_window_t is uint32_t (see xproto.h), and it's passed as
EGLNativeWindowType in compositor-x11.c,
so if EGLNativeWindowType is void * I'm getting this warning:

compositor-x11.c: In function 'x11_compositor_create_output':
compositor-x11.c:887:3: warning: passing argument 2 of
'gl_renderer_output_create' makes pointer from integer without a cast
[enabled by default]
In file included from compositor-x11.c:52:0:
gl-renderer.h:78:1: note: expected 'EGLNativeWindowType' but argument
is of type 'xcb_window_t'

Regards
Vasily

> OK, thanks, will try that and send patch tomorrow.
>
> Regards
> Vasily
>
>> On Tue, Jan 8, 2013 at 5:09 PM, Vasily Khoruzhick <anarsoul at gmail.com> wrote:
>>>
>>> +typedef int EGLDisplay;
>>> +typedef int EGLSurface;
>>> +typedef long int EGLNativeDisplayType;
>>> +typedef long int EGLNativeWindowType;


More information about the wayland-devel mailing list