[PATCH] fbdev: Add an fbdev compositor backend using pixman and evdev

[Pekka Paalanen]

On Tue, 15 Jan 2013 14:08:10 +0000
Philip Withnall <philip at tecnocode.co.uk> wrote:

> This is an initial version of an fbdev backend for Weston. I don't
> consider it polished; I'm just looking for rough feedback at the
> moment. The work is also available as a gitorious branch if anyone
> prefers that:
> https://gitorious.org/~pwithnall/weston/pwithnalls-weston/commits/compositor-fbdev
> 
> One concern I have is that a lot of the input/evdev code was copied
> verbatim from the rpi backend. It should probably be factored out into
> evdev.c or something.
> 
> 
> Initial version of a frame buffer backend using pixman to render to fbdev.
> This has been tested against nouveaufb but nothing else. Much of the code
> came straight from the rpi backend (and copyright has been attributed
> accordingly).
> 
> The behaviour of this backend on less modern frame buffers has yet to be
> tested.
> 
> Signed-off-by: Philip Withnall <philip at tecnocode.co.uk>
> ---
>  configure.ac           |  10 +
>  src/Makefile.am        |  26 +-
>  src/compositor-fbdev.c | 828 +++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 863 insertions(+), 1 deletion(-)
>  create mode 100644 src/compositor-fbdev.c

Hi Philip,

for an unpolished version, and considering that I don't know fbdev
specifics, this looks very good.

That's actually quite a small diff, especially considering all the code
that could be shared with other backends.

What do you have in mind for polishing? If it is the evdev and VT code
sharing between several backends, you will find that the android
backend will make it not so nice. IMO we could merge fbdev backend, and
refactor code later.

There is a person who has been planning on working on the android
backend, I just pinged him again. If it turns out that he cannot work
on the android backend, I will send a patch removing the android
backend. That should help the refactoring. We will see.


Thanks,
pq