[PATCH] Kmscon wlterm: Fix stuck key repeat bug

David Herrmann dh.herrmann at googlemail.com
Sun Jan 27 06:33:05 PST 2013

Hi Martin

On Sat, Jan 26, 2013 at 12:09 PM, Martin Minarik
<minarik11 at student.fiit.stuba.sk> wrote:
> 1. Depress Shift
> 2. Depress K
> 3. Release Shift
> 4. Release K
> Observed: key stuck repeat
> Expected: key not stuck repeating
> ---

This patch solves your particular problem, however, it isn't the
correct way to go. See this scenario:
  - press a
  - press b
  - release a
You would expect 'b' to be still repeated after this, however, with
this patch it won't. kmscon does it the right way (see
uterm_input_uxkb.c), however, wlterm still uses keysyms to check for
key-repeat (which is obviously wrong) and this whole thing needs to be
converted to use keycodes for keyrepeat.

I applied your patch as it is still the better behavior than before.
However, I have to rework that thing to work exactly as expected.


More information about the wayland-devel mailing list