[PATCH] xdg_shell: Add a new shell protocol.

Rafael Antognolli antognolli at gmail.com
Mon Jul 8 11:04:24 PDT 2013


On Mon, Jul 8, 2013 at 11:56 AM, Rob Bradford <robert.bradford at intel.com> wrote:
> If we're talking changes...
>
> Let's make the popup return an object with a done event on rather than
> stick the event in the interface like popup_done is.

So, you want that set_popup automatically sending a done event after
called? Then set_transient should also do the same, right?

Anyway, I can do it in a change after this one, since here I'm just
copying the files and changing the names, right?

Or maybe I didn't get what you want...

> I'd also like to see us standardise on the naming of the request to
> create the new object - I think create_xdg_surface is better than
> get_xdg_surface and aligns with the create_surface request on
> wl_compositor.

OK, added that to the new patch. We end up with:

interface: xdg_shell
  - function create_xdg_surface

interface: xdg_surface

Is this good?

Ah, the new patch went to another thread, I guess that I should have
used --chain-reply-to to avoid that.

Regards,
--
Rafael Antognolli


More information about the wayland-devel mailing list