[PATCH wayland] connection: Handle empty signature and signature with just a version.

Kristian Høgsberg hoegsberg at gmail.com
Fri Jul 12 18:52:49 PDT 2013


On Wed, Jul 10, 2013 at 11:40:56PM +0200, Mariusz Ceier wrote:
> Functions like wl_argument_from_va_list expect from get_next_argument,
> to initialize details->type but when the signature is empty or contains
> only version (like in desktop-shell-protocol.c in weston) it is left
> uninitialized.
> 
> This patch fixes it, by initializing details->type with '\0' value,
> signaling end of arguments.
> 
> Signed-off-by: Mariusz Ceier <mceier+wayland at gmail.com>

Good catch, thanks.

Kristian

> ---
>  src/connection.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/connection.c b/src/connection.c
> index 2ca9bce..9bb850c 100644
> --- a/src/connection.c
> +++ b/src/connection.c
> @@ -419,6 +419,7 @@ get_next_argument(const char *signature, struct argument_details *details)
>  			details->nullable = 1;
>  		}
>  	}
> +	details->type = '\0';
>  	return signature;
>  }
>  
> -- 
> 1.8.3.2
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list